Topic Closed
juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

There is at least one little glitch with the new visibility setting and I have to admit that I myself am not completely certain how to solve it.
 

Generally, the hidden status of a page will be maintained if a page is removed from a menu (that's desirable).

If a page is set to hidden in Main Menu, it's children will inherit the hidden status (also a good and intuitive feature - basically, but only at first glance)

Children of hidden pages may not be set to public. Hmm… why not? Of course, a hidden parent (menu entry) should prevent to render it's children *in this menu* but it should not force the children's general visibility status, because…

Pages which are children of hidden pages in Main Menu may also be part of other menus. Now I wonder, if they should be allowed to be visible then?
Currently, setting visibility in other menus acts erratic and, if it worked, it would still be hard to understand.

How to solve this without overly complicating it?

Do we need 2 types of invisibility: Page associated visibility and a menu-inherited one? I don't think so.

My proposal: Abandon menu-inherited visibility.  Of course, child pages will not render in a navigation if the parent page is hidden here. But they shouldn't be inaccessible in general. So IMO, the only thing we need is some sort of highlighting that indicates that a child branch of a hidden parent page *will not render* in the navigation - but that's solely menu related. I think "Visibility" should expicitly and solely be a page property and not be inherited in any way.

What do you think?

 

Edited: 4 years ago#8384

a2exfr
242 Posts
26.3K Downloads
2 Themes
10 Plugins

Pages which are children of hidden pages in Main Menu may also be part of other menus.

My proposal: Abandon menu-inherited visibility. 

vote +

4 years ago#8390

Josh S.
2K Posts
283K Downloads
16 Themes
18 Plugins

So if we have a main menu like so:

  • A
    • B
      • C

What does the menu look like to the user when B is hidden, but C is visible?

4 years ago#8391

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

What does the menu look like to the user when B is hidden, but C is visible?

It should only render A

4 years ago#8392

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

In my opinion, if 'vis' => 'private' in $gp_titles gpEasy should ...

  1. make the corresponding page hidden and generally inaccessible for visitors (like it already does)
  2. prevent rendering any child pages in all menus, regardless if they are hidden or not
4 years ago#8393

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects
... and page manger should illustrate this rendering behavior in some way.
4 years ago#8394

Josh S.
2K Posts
283K Downloads
16 Themes
18 Plugins
Sounds good to me, though I'm not sure how we illustrate the different rendering behaviours in the page manager
4 years ago#8395

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

maybe this is sufficient? (see png)

4 years ago#8397

Josh S.
2K Posts
283K Downloads
16 Themes
18 Plugins
Just made the changes.
4 years ago#8417

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

Yeah, I think this kind of highlighting makes it quite clear that child pages of a hidden parent will not render in a menu.

But the vis switch of hidden parents' child pages still goes away and I also get "There was an error processing the last request" when draggin pages, although the action seems to actually work server-side, so only the reponse seems to contain errors.

I also get some Warnings when creating new pages.
But this all happens with a "updated" system where I only replaced the /include dir (and with tons of plugins installed :-), so maybe it shouldn't be taken too seriously.

I'll test it with a fresh RC1 install shortly and report back.

Edited: 4 years ago#8436

Josh S.
2K Posts
283K Downloads
16 Themes
18 Plugins

I also get "There was an error processing the last request"

There is a bug in RC1 that will cause that message to appear

Edited: 4 years ago#8438

Topic Closed

 

News

elFinder 2.1.50 in Upcoming Release
12/28/2019

A new release for Typesetter is in the works with a lot of improvements including the ... Read More

Typesetter 5.1
8/12/2017

Typesetter 5.1 is now available for download. 5.1 includes bug fixes, UI/UX improvements, ... Read More

More News

HH-Support

Company located in T├│rshavn, Faroe Islands. * Webpage Design * Consultant & Provider of a wide range of programs for visually impaired and dyslextics.

Find out more about our Provider Spotlight

Log In

  Register