Plugins » Responsive Image 1.5.6

Broken support for TS<5.2
Topic Closed
mahotilo
24 Posts

On old site with TS 5.1 a user had a proposition to update plugin. And he agreed.

But after update he can't edit section.

An error message  is about '/include/thirdparty/ckeditor/ckeditor.js'

Edited: 4 months ago#11645

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

Should actually work because of

    $ckeditor_basepath = (version_compare(gpversion, '5.1') > 0) ?
      \gp\tool::GetDir('/include/thirdparty/ckeditor/') :
      \gp\tool::GetDir('/include/thirdparty/ckeditor_34/');

    echo 'CKEDITOR_BASEPATH = ' . \gp\tool\Output\Ajax::quote($ckeditor_basepath) . '; ';
    echo 'var gp_RI_ckconfig = ' . \gp\tool\Editing::CKConfig($options, 'json', $plugins) . '; ';

    // extra plugins
    echo 'var gp_add_plugins = ' . json_encode($plugins) . ';';

    $scripts[] = (version_compare(gpversion, '5.1') > 0) ?
      '/include/thirdparty/ckeditor/ckeditor.js' :
      '/include/thirdparty/ckeditor_34/ckeditor.js';

But it seems as I have to check it again

4 months ago#11646

mahotilo
24 Posts

Well. 

I checked it again on user's site. It has not a clear TS from .com, but a master from github. This master dates back to 2017 and has version number Typesetter 5.1.1-b1.

Tada!

I think it is time to change the version on github and in your (and mine) checks.

4 months ago#11647

juergen
1.5K Posts
54.4K Downloads
16 Plugins
design, web development & visual effects

> I think it is time to change the version on github

Yes, there have been too many changes to keep the b1 version number.
But it's also the price tag for using betas. It's only rc that will not change/add features anymore.

4 months ago#11650

Topic Closed

 

News

elFinder 2.1.50 in Upcoming Release
12/28/2019

A new release for Typesetter is in the works with a lot of improvements including the ... Read More

Typesetter 5.1
8/12/2017

Typesetter 5.1 is now available for download. 5.1 includes bug fixes, UI/UX improvements, ... Read More

More News

creisi productions

Dienstleistungen von creisi productions, Luzern (Schweiz): * Konzeption, Planung und Erstellung Ihres Internet-Auftritts * Betreuung und Aktualisierung/Pflege Ihrer Website * ...

Find out more about our Provider Spotlight

Log In

  Register